search

chef-cookbooks / supermarket-omnibus-cookbook

A cookbook for installing supermarket from Omnibus (deb, rpm) packages
Apache License 2.0
17 stars 29 forks source link

Upgrade the omnibus install when version changes. #40

Closed robbkidd closed 8 years ago

robbkidd commented 8 years ago

The chef_ingredient install action was not installing a newer version of the omnibus package if a newer version was declared.

nellshamrell commented 8 years ago

🚀 🍰

irvingpop commented 8 years ago

Apologies it's been a while since I dug into the underlying logic. Could you imagine this change doing anything unexpected to existing users of the cookbook?

robbkidd commented 8 years ago

I don't think it will add any more unexpected things than before we updated this cookbook to use the new chef_ingredient. Before, it was action :install with an APT or YUM package resource which was in effect an upgrade. chef_ingredient now—unless a custom repo recipe is given—remote_file downloads the supermarket omnibus package from packages.chef.io and installs via dpkg or rpm. In testing on Ubuntu with a version specified in node['supermarket_omnibus']['package_version'], this cookbook would not install a newer version than what is already installed on a node without changing the action to :upgrade.

irvingpop commented 8 years ago

Good to know! đź‘Ť

robbkidd commented 8 years ago

Thanks for your eyeballs, @irvingpop!