search

chef-cookbooks / supermarket-omnibus-cookbook

A cookbook for installing supermarket from Omnibus (deb, rpm) packages
Apache License 2.0
17 stars 29 forks source link

upgrade/downgrade should restart services #52

Open kplimack opened 7 years ago

kplimack commented 7 years ago

I just installed that lastest version via supermarket-omnibus-cookbook and it did not restart the processes. I could still see the ddtrace errors until I ran supermarket-ctl restart. This should be automatic.

Cookbook version

supermarket-omnibus-cookbook 2.0.1

Chef-client version

chef-12.13.37-1.el6.x86_64

Platform Details

CentOS 6.8

Steps to Reproduce:

perform an upgrade via cookbook by setting version.

default['supermarket_omnibus']['package_version'] = '2.9.15'

Expected Result:

supermarket restarts and runs on the desired version without manual restart

Actual Result:

old version of code is still running

iennae commented 7 years ago

Based on looking at the code, this looks like a problem with the chef_ingredient resource as this action is to upgrade and reconfigure in this cookbook. We'll need to confirm. Thanks for reporting.

robbkidd commented 7 years ago

Because a restart causes a brief outage on a Supermarket node, we have so far not made the restart automatic. Certainly open to feedback about use cases and maybe providing a flag for enabling/disabling auto-restart.

Also, we're considering a move to encouraging folks installing private Supermarkets to use chef-ingredient directly in their wrapper cookbooks which would (1) expose the hooks for restarting directly at the discretion of the wrapper authors and (2) remove one layer of abstraction/indirection.

iennae commented 7 years ago

After syncing up with @robbkidd realized that it's intentionally not calling for a restart. As @robbkidd mentions in previous comment with regards to restart, it is intentionally not restarting because folks might not want to have their Supermarket go down at a random time based on their configuration. The process of upgrading a particular service can have many meanings depending on who is doing the installation/upgrading. We'll get this better documented so folks understand what is happening here. Thanks for filing this issue.