CHEF-12487 certs added to backend deployment and trimspace to prevent restart - Githubissues

chef / automate

Chef Automate provides a full suite of enterprise capabilities for maintaining continuous visibility into application, infrastructure, and security automation.

https://automate.chef.io/

Apache License 2.0

227 stars 113 forks source link

CHEF-12487 certs added to backend deployment and trimspace to prevent restart #8632

Closed vivekshankar1 closed 1 month ago

vivekshankar1 commented 1 month ago

:nut_and_bolt: Description: What code changed, and why?

:chains: Related Resources

https://progresssoftware.atlassian.net/browse/CHEF-12487

packages for testing:

vivek-shankar/automate-ha-deployment/0.1.0/20241016112616
vivek-shankar/automate-cli/0.1.0/20241016114018

Demo: https://progresssoftware.sharepoint.com/:v:/s/ChefCoreC/EboMQAaIlhdMo2W5yTO_MyQBkWu4qcy7zbjVgfK4sSub3Q?e=iVYfBh

:+1: Definition of Done

:athletic_shoe: How to Build and Test the Change

:white_check_mark: Checklist

All PRs must tick these:

[ ] I have read the CONTRIBUTING document.
[ ] All commits signed-off for the Developer Certification of Origin.

With occasional exceptions, all PRs from Progress employees must tick these:

[ ] Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
[ ] Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
[ ] Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
[ ] Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
[ ] Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

[ ] Tests added/updated? (all new code needs new tests)
[ ] Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

:camera: Screenshots, if applicable

netlify[bot] commented 1 month ago

Deploy Preview for chef-automate processing.

Name	Link
Latest commit	b296df9120c4b76fb1c4fe7d72caedf3484e5b25
Latest deploy log	https://app.netlify.com/sites/chef-automate/deploys/671748edae45e900086bb3f3

sonarqube-for-infrastructure-prod[bot] commented 1 month ago

Quality Gate failed

Failed conditions
4 New issues
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint