[SandboxesEndpoint#put] Move checksum discovery out of loop - Githubissues

chef / chef-zero

Simple, easy-run, fast-start in-memory Chef server for testing and solo purposes

Apache License 2.0

532 stars 98 forks source link

[SandboxesEndpoint#put] Move checksum discovery out of loop #328

Closed dafyddcrosby closed 6 months ago

dafyddcrosby commented 6 months ago

Description

This endpoint does N number of checksum checks, which can be really expensive when the N is large on the available server checksums and/or the client checksum requests

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[X] I have read the CONTRIBUTING document.
[X] I have run the pre-merge tests locally and they pass.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
[X] All new and existing tests passed.
[X] All commits have been signed-off for the Developer Certificate of Origin.

tpowell-progress commented 6 months ago

Pending rebase on a PR that removes 2.6

sonarcloud[bot] commented 6 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud