Reverting FFI because 1.16.3 breaks Windows Registry monkey patches

johnmccrae commented 5 months ago

Description

We updated the FFI dependency here to 1.16.3. That required updating Chef-17 to use FFI 1.16.3. As a consequence of that update in Chef-17, the windows registry monkey patch stopped loading and that lead to a recurrence of the error that the monkey patch was fixing to begin with. We spent a fair bit of time trying to debug the issue and ultimately decided to fall back since Chef-17 was going to EOL in 6 months.

Related Issue

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] I have run the pre-merge tests locally and they pass.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
[ ] All new and existing tests passed.
[ ] All commits have been signed-off for the Developer Certificate of Origin.

sonarcloud[bot] commented 5 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

johnmccrae commented 5 months ago

This was not the problem. It was the inclusion of the Resolv class in a the previous PR that in turn unconditionally loads the WIn32/Registry class which was stepping on the monkey-patch. Closing

chef / ohai