chembl / GLaDOS

Web Interface for ChEMBL @ EMBL-EBI
https://www.ebi.ac.uk/chembl/
Other
46 stars 6 forks source link

Make report cards Xframe options exempt to allow embedding #1203

Closed nclopezo closed 4 years ago

pep8speaks commented 4 years ago

Hello @nclopezo! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 230:102: W291 trailing whitespace Line 237:100: W291 trailing whitespace Line 257:108: W291 trailing whitespace Line 263:102: W291 trailing whitespace

chembl-bot commented 4 years ago

I am going to a start test server for 5cd656437b2f4b3831179bac169a0e7a12c92d3d

chembl-bot commented 4 years ago

Starting Ghost inspector tests on http://wwwdev.ebi.ac.uk/chembl/test2/make-xframe-options-exempt/

chembl-bot commented 4 years ago

Ghost inspector tests results, passed: True

Tested Commit: 5cd656437b2f4b3831179bac169a0e7a12c92d3d

Suite Name: Basic

All passing: True

Suite Name: Report Cards

All passing: True

Suite Name: ReportCards - Compound

All passing: True

Suite Name: State URLs and Query editing

All passing: True

Suite Name: Downloads

All passing: True

Suite Name: Sequence and Structure Searches

All passing: True

Suite Name: Redirections

All passing: True

nclopezo commented 4 years ago

DO NOT MERGE. Until the questions in https://helpdesk.ebi.ac.uk/Ticket/Display.html?id=372964 are answered.