cheminfo / biologic-converter

MIT License
1 stars 2 forks source link

test: new datafiles structure #24

Closed ghost closed 1 year ago

ghost commented 1 year ago

The datafiles were spread all over and that made quite difficult to check what we have and what is being tested. Also some were repeated.

Now all the tests use the same data folder, there is hopefully no repetition, plus a few test-only updates in how to import from node js.

todo: will update with a log object from convert so that we can have errors, logs etc as in nmr parser.

codecov[bot] commented 1 year ago

Codecov Report

Base: 96.02% // Head: 94.93% // Decreases project coverage by -1.08% :warning:

Coverage data is based on head (1e44de9) compared to base (efcbce4). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #24 +/- ## ========================================== - Coverage 96.02% 94.93% -1.09% ========================================== Files 25 25 Lines 553 553 Branches 154 154 ========================================== - Hits 531 525 -6 - Misses 21 27 +6 Partials 1 1 ``` | [Impacted Files](https://codecov.io/gh/cheminfo/biologic-converter/pull/24?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cheminfo) | Coverage Δ | | |---|---|---| | [src/mpr/modules/utility/mapIRangeToMPT.ts](https://codecov.io/gh/cheminfo/biologic-converter/pull/24/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cheminfo#diff-c3JjL21wci9tb2R1bGVzL3V0aWxpdHkvbWFwSVJhbmdlVG9NUFQudHM=) | `77.58% <0.00%> (-6.90%)` | :arrow_down: | | [src/convert.ts](https://codecov.io/gh/cheminfo/biologic-converter/pull/24/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cheminfo#diff-c3JjL2NvbnZlcnQudHM=) | `95.23% <0.00%> (-4.77%)` | :arrow_down: | | [src/utility/getParamsFromText.ts](https://codecov.io/gh/cheminfo/biologic-converter/pull/24/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cheminfo#diff-c3JjL3V0aWxpdHkvZ2V0UGFyYW1zRnJvbVRleHQudHM=) | `94.28% <0.00%> (-2.86%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cheminfo). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cheminfo)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.