search

chenejac / VIVOTestMigrationJIRAClosed

0 stars 0 forks source link

VIVO-1986: RDF syntax errors obscured by TDB transaction handling bug #12

Closed chenejac closed 3 years ago

chenejac commented 3 years ago

Brian Lowe (Migrated from VIVO-1986) said:

To reproduce, go to Add/Remove RDF data, select N3 syntax, and try to upload a text file that is not a valid N3 file.  The error reported to the user is the following, rather than the actual syntax error:

Could not load from file: edu.cornell.mannlib.vitro.webapp.rdfservice.RDFServiceException: org.apache.jena.sparql.JenaTransactionException: end() called for WRITE transaction without commit or abort having been called. This causes a forced abort.

 

In RDFServiceTDB, method changeSetUpdate() should probably catch any exceptions thrown in applyChangeSetToModel() and call an explicit dataset.abort() before rethrowing.

chenejac commented 3 years ago

Brian Lowe said:

Vitro pull request: https://github.com/vivo-project/Vitro/pull/230

chenejac commented 3 years ago

Brian Lowe said:

Resolved in commit https://github.com/vivo-project/Vitro/commit/3c04cc0f8012767cff51dbaf80b196f6ceb8eb6c