search

chenglou / react-motion

A spring that solves your animation problems.
MIT License
21.7k stars 1.15k forks source link

React 16 for demos #498

Open nkbt opened 7 years ago

nkbt commented 7 years ago

react-hot-reload 1.x does not support React 16 (uses react/lib/*).

As far as I tried react-hot-reload 3.x it was not working as expected, so at this point I will remove hot-reload entirely and we can re-iterate later.

Used yarn to install deps and added yarn.lock. Updated travis config to use yarn too (and node 8)

chenglou commented 7 years ago

Oh well ¯_(ツ)_/¯

Thanks, merged!

chenglou commented 7 years ago

Actually the build is failing?

nkbt commented 7 years ago

Yeah, there is some issue with phantomjs. I need to dig a bit more

nkbt commented 7 years ago

I've reverted travis back to node6 and npm for now. Don't have much time these days =(. When I'm back from holidays, will update all deps and make sure everything builds properly (and fast).

nkbt commented 7 years ago

Oh dear what's wrong this time?

02 10 2017 23:24:32.292:WARN [launcher]: Can not load "PhantomJS", it is not registered!
  Perhaps you are missing some plugin?