search

chenqingspring / ng-lottie

Render After Effects animations on Angular based on lottie-web
MIT License
340 stars 100 forks source link

fix(safari): add locationHref to fix clipPath issues in safari #35

Open damienwebdev opened 6 years ago

damienwebdev commented 6 years ago

Expected Behavior

When I use a lottie animation that has a clipPath with angular, I should expect the same results across browsers.

Current Behavior

In safari, when using an animation that uses clipPath, the mask/clipPath won't apply due to the <base href="/"> that is used by default in angular.

Related issue

In github.com/airbnb/lottie-web - https://github.com/airbnb/lottie-web/issues/914

Fixes #36

Related PRs

https://github.com/airbnb/lottie-web/pull/382

ydagana commented 5 years ago

@damienwebdev Great find, but why hasn't this been merged yet? @chenqingspring can you please merge this and update the repo?

damienwebdev commented 5 years ago

@ydagana I think @chenqingspring rarely checks this project, so I'm not sure when we'd get an update.

jcbreel commented 5 years ago

Having the same issue... Anyone found a solution?

boost-app commented 5 years ago

I forked the fix of @damienwebdev into a repo with the build files checked in as well. This way you can install it via npm i https://github.com/teamgeist-app/ng-lottie.git and have it work on ios.

But be aware: I WON'T KEEP THE REPO UP TO DATE! SWITCH TO THE ORIGINAL REPO ONCE THE PR IS MERGED