cherab / core

The core source repository for the Cherab project.
https://www.cherab.info
Other
45 stars 24 forks source link

Add access to plasma model properties #294

Open Mateasek opened 3 years ago

Mateasek commented 3 years ago

Currently PlasmaModel attributes are not accessible from python. Making some of them accessible would provide an easier way of investigating and understanding results provided by cherab. I think in general it would increase the usefulness of the plasma object and sometimes save a lot of time. For example reaction rates could be obtained from the plasma object instead of the need to construct them manually. This could be also useful for debugging of simulations. I propose adding getters to:

ExcitationLine, ExcitationLine:

TotalRadiatedPower:

Are there any more objections to this idea? There can be a reason for the current state which I missed. Also are there any more ideas which could be connected to this change?

jacklovell commented 3 years ago

I don't see any harm in doing this. You should ensure that the documentation is updated too, to include these properties.