chestrays / cornerstone_widget

A jupyter widget for the cornerstone library to make showing flashy images with nice tools easier.
Apache License 2.0
26 stars 2 forks source link

Adding Browser-based tests #9

Closed kmader closed 6 years ago

kmader commented 6 years ago

adding casper-based browser tests (based on the gist from @ellisonbg https://gist.github.com/ellisonbg/3329929)

betatim commented 6 years ago

Should we try and finish this off or close/take a new approach?

This is the robot framework I was talking about that others use to do UI based testing.

kmader commented 6 years ago

Any examples of repos using Robot with Travis? Do we just pip install, add the robot kernel, and then nbconver a robot notebook?

betatim commented 6 years ago

Good question. I will dig around a bit.

datakurre commented 6 years ago

@betatim FYI. I've now made a release of robotkernel and for me it seems that nbconvert should work. Note that if you use headless Firefox, geckodriver must be downloaded into path separately.

bollwyvl commented 6 years ago

geckodriver must be downloaded into path separately

If you're on the conda bus, you still have to install firefox and chrome yourself, but...

... are all conda-forged.

Here are some examples of testing Jupyter(Lab) with robot:

I keep meaning to capture all of these in a library, but continue to eat the copy-pasta.

kmader commented 6 years ago

@datakurre @bollwyvl thanks for the links, they look like a great start. I will close this PR and make a new one since my code here is not a great start. I might come back to you if it all blows up but it seems straightforward enough.