search

chevah / pythia

Chevah's Python 3 distribution
MIT License
4 stars 2 forks source link

Change how Windows packages are generated #15

Closed dumol closed 1 year ago

dumol commented 3 years ago

A very minor comment regarding:

   runs-on: [ windows-2019, windows-2016 ]

The current x64 vs x32 bit build design was shaped by buildmaster limitation.

In an ideal world we would have a matrix in which we define which windows version to run and also decide which bit version... so that we could also build x32 on 2019.

so the 32 vs 64 build decision is not made by brink.sh / pythia.sh but by the env variables.

Originally posted by @adiroiban in https://github.com/chevah/pythia/pull/14#r538488260

dumol commented 1 year ago

Obsoleted. Only x64 is supported on Windows.