Closed dumol closed 3 years ago
great work. I think that we can have the job defined in the main workflow .
great work. I think that we can have the job defined in the main workflow .
Yeah, I don't know, let's see how verbose it turns out in the end. I hope to use a matrix for everything but Centos 5 and 6.
- uses: chevah/auto-cancel-redundant-job@v1 can be removed as it no longer works.
You need to use the new "concurency" feature from GitHub like we have at
Thanks, I'll look into it.
Also
fetch-depth: 2
can be removed... I think that it was only used for ourskip-ci
hack... but now GitHub has native support.
I have removed it once and then put it back because I realize it is actually needed. Can't recall the details though, so perhaps I'll remove it again to document it better if this is still the case.
Also fetch-depth: 2 can be removed
This was a very minor comment... I think that we can also leave it as it is as it does no harm.
Scope
Containerized builds for Linux distros not supported through GitHub's own runners.
Fixes #4.
Fixes #8 (makes it superfluous).
Changes
Build on the work in https://github.com/chevah/server/pull/1744 to add containerized builds for:
Drive-by changes:
python-package
.cryptography
to 3.4.7.pip
to latest version.Have experimented with building
cryptography
with Rust. On pypi.chevah.com, the following new modules were needed:semantic_version
andsetuptools_rust
.In the end, have built
cryptography
without Rust, because it would have added one more dep:libgcc
(which is more or less an essential package). So I've usedCRYPTOGRAPHY_DONT_BUILD_RUST=1
.Testing
Please review changes.
Check the automated tests and the resulting uploads to https://bin.chevah.com:20443/testing/3.8.6.ee5d7c0/.