search

chevah / pythia

Chevah's Python 3 distribution
MIT License
4 stars 2 forks source link

Migrate Py2 cache without having to purge. #24

Closed danuker closed 3 years ago

danuker commented 3 years ago

Scope

I ran into the missing /lib/PYTHIA_VERSION on the GH runners here. It seems it was not just pebkac :)

Changes

I believe touching the PYTHIA_VERSION file lets us reuse the old Python 2 cache without having to ./brink.sh purge, and that it updates as needed.

As such, I suggest adding the command in brink.sh.

Then again, this is my first PR here, and I just familiar enough with the script to be dangerous. So don't trust this PR!

Testing

  1. Check out a Python 2 version of a repository (for example, brink on current master de70366.
  2. Do a ./brink.sh deps to get the Py2 version of packages.
  3. Check out a Py3 version of a repo (for example, the 5648-py3-take2 branch).
  4. Do a ./brink.sh deps again, and see the brink.sh error. After this fix, it should work instead.
dumol commented 3 years ago

Thanks for fixing and documenting this!