chevah / pythia

Chevah's Python 3 distribution
MIT License
4 stars 2 forks source link

Update from py2 to py3. #25

Closed adiroiban closed 3 years ago

adiroiban commented 3 years ago

Scope

This is a fix for the case when a py3 is updated on top of an existing py2 base code. The problem is that py2 pyc files exist in the repo, and when migrating to py3 they are not updated (as they match the timestamp) but they will fail as they are not py3 bytecode.

I hope that with this PR we can close the loop and have 100% py3 code on pyhtia.

Changes

Remove pyc files after updating python.

Drive-by changes:

Testing

reviewers: @dumol @danuker

1.Python update

Manual update brink.conf to have a py2 version. Get the python2 environment and make sure you have pavement.pyc file generated. Update brink.conf to have have a py3 version. Update the deps. The environment should be automatically updated. You should not see any "bad magic number" errors.

2.Actions try

For now, action_try is limited and is not a 100% replacement for buildbot

It can only select a job ... and can't select a specific run inside a matrix

$ paver actions_try -w bare.yaml -j linux
adiroiban commented 3 years ago

needs-review

@dumol for centos-5 I get this error - https://github.com/chevah/pythia/pull/25/checks?check_run_id=2784487747#step:5:19

http://vault.centos.org/5.11/os/x86_64/repodata/repomd.xml: [Errno 4] IOError: <urlopen error (99, 'Cannot assign requested address')>
Trying other mirror.
Error: Cannot retrieve repository metadata (repomd.xml) for repository: base. Please verify its path and try again
dumol commented 3 years ago

Also, this:

DEPRECATION: The -b/--build/--build-dir/--build-directory option is deprecated and has no effect anymore. pip 21.3 will remove support for this functionality. A possible replacement is use the TMPDIR/TEMP/TMP environment variable, possibly combined with --no-clean. You can find discussion regarding this at https://github.com/pypa/pip/issues/8333.

dumol commented 3 years ago

While at it, have forward-ported all the latest brink.sh improvements from python-package in my minimal commits above. Hopefully easy to double-check… Thanks!