Closed dumol closed 1 year ago
Not sure what do about macOS, haven't invested much time into it. If you want to, take a look, maybe some things are worth reporting upstream.
Otherwise, I would just except macOS alongside Alpine Linux.
it's ok to except macOS.
thanks
Sorry for the Shellcheck drive-by fixes, it looks like they weren't run at all in master because of a late "improvement" in the previous PR. :-/
I have now used execute
for ./src/chevah-bash-tests/shellcheck_tests.sh
, should not happen again…
One thing to keep in mind is that the only platform running all tests (upstream ones for OpenSSL/Python + ours for Python&modules + security check with safety
+ bash shell checks) is glibc-based Linux. You could argue Windows is also fully covered, as we use the upstream Python/OpenSSL/cryptography, so there's no need to test what upstream has built.
My reading the code, this is mixed with compiling Python... which is a huge output, which is hard to check
I've worked on separating testing in a dedicated GHA step. Same for installing.
My preference, is to have "Pythion test" as a separate top level step.
It is a separate test, but not a top-level one. I think this kind of testing is best done where it belongs, right after compiling, but before installing. This way, if testing fails, the build is stopped right there, no need to continue with building other libraries.
I think that this can be merged. thanks!
Scope
Fixes #12
Changes
Enabled the Python tests on the platforms where we build it, with the exception of:
Drive-by fixes:
paxctl
.chevabs
functions for testing and installing to have them listed distinctly in GHA output.libffi
,bzip2
,xz
,zlib
.Testing
Automated.