search

chigozienri / VQGAN-CLIP-animations

134 stars 28 forks source link

Fixed random Seed does not create the same results #28

Open rs3dtouch opened 3 years ago

rs3dtouch commented 3 years ago

Using a fixed random seed does not produce the same result, even with an _initialimage as starting point.

I guess there are different seed values in some sub routines - do you think it is possible to fix all these to make 100% reproducible results?

My hope would be, that animation would get more stable then. But maybe I'm wrong and this would not help to tame the temporal incoherence...

chigozienri commented 3 years ago

Good catch, sorry for the delay. Unfortunately I don't think this will affect the consistency from one frame to the next, just fix results between runs. I would accept a PR that addressed this, but I expect it's deep in the guts of PyTorch somewhere, and the expected benefit doesn't seem big enough for me to devote time to right now (even though I agree that it would be nice to have a fix).

chigozienri commented 2 years ago

@rs3dtouch I have found something that I think I could build into a solution to make this reproducible, but it would take some work, and would more memory/reduce performance. I don't think it's worth it (and I am sure it won't affect the animation stability) but if you think it would be useful for reasons other than animation stability, I could work on a toggle for it.