search

chiiida / survey-app

An iOS survey app code challenge build with Swift
0 stars 0 forks source link

Separating functionality in ViewControllers #9

Open edgarss opened 3 years ago

edgarss commented 3 years ago

Since this is a code challenge, using MVC architecture for the app is fine, but you should watch out for function length and readability. For example In most cases you use setUpLayout to only set the layout of view elements, but in LoginScreenViewController you are also modifying the textfields in that function which would be better to have in a seperate function.

chiiida commented 3 years ago

Thanks for your feedback. I updated the code and open this pull request #13.