search

chikako0219 / sharedpanel

Plugin for Moodle
2 stars 2 forks source link

all user-facing strings should be within the lang file #8

Closed danmarsden closed 6 years ago

danmarsden commented 7 years ago

You have several places in the code where you have hard-coded english text - these should be moved into the lang files to allow translation: example:

https://github.com/chikako0219/sharedpanel/blob/master/importcard.php#L61 https://github.com/chikako0219/sharedpanel/blob/master/twitter.php#L110

(there are many other areas of your code that do this and need to be fixed)

takayuki-fuwa commented 6 years ago

Fixed to get_string().