search

childmindresearch / niwrap

https://childmindresearch.github.io/niwrap/
9 stars 8 forks source link

Add Mrtrix3Tissue fork #156

Closed kaitj closed 2 months ago

kaitj commented 2 months ago

Adds the Mrtrix3 fork, Mrtrix3Tissue. It only adds a single ss3t_csd_beta1 that is made available in the fork + all of the mrtrix3 commands. Figured it'd be good to have it encapsulated for the container runs to avoid potentially downloading 2 different containers. There are a few differences between them (some bug fixes and changes in default params).

(Should we add a new label for this?)

nx10 commented 2 months ago

Looks good in principle - do we need to copy all commands? / Has mrtrix3tissue diverged significantly from mrtrix3? If yes we might want to re-generate them from its sources

nx10 commented 2 months ago

If it has not diverged that much we could also just provide the new commands and if users want to use the forks image they may override the image

kaitj commented 2 months ago

It hasn't diverged too much aside from any bug fixes mrtrix may have introduced from 3.0.2 -> 3.0.4 (from what I gather). I was debating about including all of the commands too since its really only 1 command that has been added. The only place where having all of the commands is potentially helpful is saving time / space having 2 different containers / installations.

nx10 commented 2 months ago

I see, yeah in that case I'd vote to just ship the 1 command for mrtrix3tissue

kaitj commented 2 months ago

Sounds good, then let me just remove the last commit then this should be good.