search

chime / terraform-aws-alternat

High availability implementation of AWS NAT instances.
MIT License
1.06k stars 66 forks source link

Remove deprecated vpc argument to aws_eip #80

Closed ascandella closed 1 year ago

ascandella commented 1 year ago

The vpc = true is throwing deprecation diagnostics. It still works this way, but is not referenced in the documentation anymore.

Screenshot 2023-09-28 at 7 49 50 AM

Ran a terraform plan against my forked version and the plan came up clean (no changes) without any of the warning diagnostics.

ascandella commented 1 year ago

Ah cool, good point. The docs all show with domain = "vpc" so I assumed it was necessary to get it to do the right thing.

But I just tested a terraform plan and it came up clean with removing the line entirely. Reading the docs it seems like the domain = "vpc" might be a bit safer in case anybody is running this in a VPC with EC2 classic, but it also looks like that may finally be deprecated?

I haven't tested destroying and re-creating the EIP with this branch, though.

bwhaley commented 1 year ago

Worked for me. Thanks for the contribution!