Tab key not working in JS editor when using CodeMirror

chinchang / web-maker

A blazing fast & offline frontend playground

https://webmaker.app

MIT License

2.57k stars 316 forks source link

Tab key not working in JS editor when using CodeMirror #546

Closed nhogle closed 11 months ago

nhogle commented 12 months ago

Meta info

bug
Version 5.0.3
Context: Web app (and probably Chrome Extension, but I did not test)
Chrome Version: 116.0.5845.188

The Tab key does nothing when using the default editor, CodeMirror. This is due to a logical bug in the code, whereby the Emmet option check will short-circuit the logic that should actually handle the Tab keyboard key.

nhogle commented 12 months ago

@chinchang : Please see PR #547. Thank you!

chinchang commented 11 months ago

merged in master. Deployed on web app. Chrome extension will be published soon.

nhogle commented 11 months ago

@chinchang That was so quick, thank you! :)