chingu-x / chingu-dashboard

https://chingu-dashboard.vercel.app
GNU General Public License v3.0
9 stars 2 forks source link

fix/Fix images #226

Closed JaneMoroz closed 2 months ago

JaneMoroz commented 2 months ago

Description

Best I can do, must be some Figma bug... just can't export it without this extra space at the bottom (dark mode version)

Issue link

Fixes #200

Type of change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chingu-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 8, 2024 3:01pm
Dan-Y-Ko commented 2 months ago

@JaneMoroz what is the issue? are the images just different sizes? Maybe the design team can help resolve this in figma

jrayDFW commented 2 months ago

Hi @JaneMoroz! We were just in the meeting with Dan and the illustrations were also exporting at different sizes for me too. I figured out that it was a drop-shadow on one of the vectors that was causing an issue with the spacing on the dark mode version. I uploaded the fixed versions to this comment. Sorry about that, and I'll keep this in mind for future illustrations. Going forward, we're going to start separating out illustrations in the Design Specs so that they will for sure be the same size and should be much easier for y'all to grab.

Let me know if these work or if they need to be sized any larger if they appear blurry.

Thanks!

Light-Final Dark-Final