Added LED_BUILTIN to Board_Defs.h

[squintz]

The Arduino project has added LED_BUILTIN to their official list of Constants. See https://www.arduino.cc/en/Reference/Constants

They have also updated their examples to use LED_BUILTIN which means it must be defined in variants of Board_Defs.h in order to compile some of their examples. This will likely be an issue in most chipKIT variants.

[EmbeddedMan]

Unfortunately this needs to be done on a per-board basis, as many boards do not have pin 13 connected to an LED. (Thus the reason Arduino went to a constant rather than using "13", because many of their boards don't have it on 13 anymore either.) Each board's variant file will need to get this define.

[majenkotech]

Why not

#define LED_BUILTIN PIN_LED1

...?

[EmbeddedMan]

Ahhh! Yes, that would work well I think.

*Brian

On Fri, Oct 28, 2016 at 3:30 PM, Majenko Technologies < notifications@github.com> wrote:

Why not

define PIN_LEDBUILTIN PIN_LED1

...?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/chipKIT32/chipKIT-core/pull/283#issuecomment-257020605, or mute the thread https://github.com/notifications/unsubscribe-auth/AAbeCHsgvC7DsbYSiGRwvN72q9FHeADGks5q4ltPgaJpZM4Kj05a .

[chipkitbot]

The build was successful, and can be seen at http://chipkitjenkins.wayneandlayne.com/job/chipKIT-core%20PR%20Builder/168/.

[JacobChrist]

This is the same at #235 and #276. Also, #235 talks about changes to SPI.

Jacob

[EmbeddedMan]

squintz, I think Matt's idea of adding just one

define LED_BUILTIN PIN_LED1

in one common place (which will work because every board's variant file will already have PIN_LED1 defined appropriately) may be a better way to go than adding this to every variant file.

[chipkitbot]

The build was successful, and can be seen at http://chipkitjenkins.wayneandlayne.com/job/chipKIT-core%20PR%20Builder/169/.

[chipkitbot]

The build was successful, and can be seen at http://chipkitjenkins.wayneandlayne.com/job/chipKIT-core%20PR%20Builder/170/.

[JacobChrist]

squintz, I think Matt's idea of adding just one

define LED_BUILTIN PIN_LED1

in one common place (which will work because every board's variant file will already have PIN_LED1 defined appropriately) may be a better way to go than adding this to every variant file.

[majenkotech]

I don't think he can hear you above the noise of the commits.

[squintz]

Oops, sorry! I was in the middle of changing it while you guys were replying. I can change it to PIN_LED1

[chipkitbot]

The build was successful, and can be seen at http://chipkitjenkins.wayneandlayne.com/job/chipKIT-core%20PR%20Builder/171/.

[squintz]

So before I go making the changes again... where would the one common place be that #define LED_BUILTIN PIN_LED1 should go? It only took a couple minutes to add it to each board file so it should only take a few minutes to undo what I did.

[chipkitbot]

The build was successful, and can be seen at http://chipkitjenkins.wayneandlayne.com/job/chipKIT-core%20PR%20Builder/172/.

[chipkitbot]

The build was successful, and can be seen at http://chipkitjenkins.wayneandlayne.com/job/chipKIT-core%20PR%20Builder/173/.

[chipkitbot]

The build was successful, and can be seen at http://chipkitjenkins.wayneandlayne.com/job/chipKIT-core%20PR%20Builder/174/.

[chipkitbot]

The build was successful, and can be seen at http://chipkitjenkins.wayneandlayne.com/job/chipKIT-core%20PR%20Builder/175/.

[JacobChrist]

pins_arduino.h?

[chipkitbot]

The build was successful, and can be seen at http://chipkitjenkins.wayneandlayne.com/job/chipKIT-core%20PR%20Builder/176/.

[squintz]

Makes sense to me. I'll close this pull request and pretend it never happened.