chocolatey-community / chocolatey-package-requests

Please submit your package requests as issues here
Apache License 2.0
95 stars 18 forks source link

RFP - visualstudio-wdk #1386

Closed gtrevi closed 1 year ago

gtrevi commented 1 year ago

Checklist

Package Details

Software project URL : https://learn.microsoft.com/en-us/windows-hardware/drivers/download-the-wdk Direct download URL for the software / installer: https://go.microsoft.com/fwlink/?linkid=2196230 Software summary / short description: to develop drivers on Win11 22H2/Visual Studio 2022, WDK version 10.0.22621.382 is required.

pauby commented 1 year ago

I updated the title to be visualstudio-wdk. However, I'm struggling to understand the difference between this and windowsdriverkit11?

github-actions[bot] commented 1 year ago

Package Request Validation

We have finished some basic validation of this request. The result of this validation can be found below:

Everything looks good to our automated checks, it is now up to a human to validate the remaining steps. No action is required yet

New Maintainer Notices

This section details some parts of the request that any upcoming maintainer may need to take into consideration.


TrID/32 - File Identifier v2.24 - (C) 2003-16 By M.Pontello
Definitions found:  15341
Analyzing...

Collecting data from file: C:\Users\RUNNER~1\AppData\Local\Temp/software.tmp
 40.3% (.EXE) Win64 Executable (generic) (10523/12/4)
 19.3% (.EXE) Win16 NE executable (generic) (5038/12/1)
 17.2% (.EXE) Win32 Executable (generic) (4505/5/1)
  7.7% (.EXE) OS/2 Executable (generic) (2029/13)
  7.6% (.EXE) Generic Win/DOS Executable (2002/3)

Please note that this check is currently in alpha, and may not be able to detect everything correctly. Humans may also be able to detect other issues with this request.

gtrevi commented 1 year ago

I updated the title to be visualstudio-wdk. However, I'm struggling to understand the difference between this and windowsdriverkit11?

No problem for the name, simply, I wasn't allowed to use that token. Adding another version to windowsdriverkit11 would be absolutely fine.

Just heads up that the WDK is not related to Visual Studio, but to windows, hence why I continued to use the windowsdriverkit** prefix.

pauby commented 1 year ago

Adding another version to windowsdriverkit11 would be absolutely fine.

Just to be clear, the windowsdriverkit11 and this package are the same thing? When we say version, we mean version number of the same thing, so when you say the above do you just mean a later / more recent version number of windowsdriverkit11 as it's outdated?

gtrevi commented 1 year ago

Let me better clarify: this is the latest, major, WDK update for developing drivers on Win 11 22H2. In my initial naming, i.e. windowsdriverkit12, I simply followed the existing logic in the current Chocolatey database:

and consequently, my proposal was:

TheCakeIsNaOH commented 1 year ago

@gtrevi My understanding of windowsdriverkit10 is that it is the WDK for Windows 10, and the windowsdriverkit11 is for the WDK for Windows 11.

As per the table here: https://learn.microsoft.com/en-us/windows-hardware/drivers/other-wdk-downloads#step-2-install-the-wdk, there are quite a few different versions of the WDK for various Windows 10 major updates, and (at the moment) two version of the WDK for Windows 11, for 21H2 and 22H2.

So, the latest version of the WDK 10.0.22621.382, is for Windows 11 22H2, correct? If so, I think it should be added as a version to windowsdriverkit11.

gtrevi commented 1 year ago

@TheCakeIsNaOH thanks for the clarifications. Yes then, absolutely agree it should go under windowsdriverkit11, as a major subversion for 22H2 (as you can see from the history, I too initially tried to use "windowsdriverkit11", but the bot will not validate it, even with variants).

TheCakeIsNaOH commented 1 year ago

Sounds good. I'll close this issue then, and you can ask the maintainer of windowsdriverkit11 to update the package.

If the maintainer is not responding for the request to update the package, then follow the package triage process: https://docs.chocolatey.org/en-us/community-repository/users/package-triage-process#the-triage-process

At the end of that process is where you would create an "RFM" issue (instead of an "RFP" issue), if the current maintainer has abandoned the package.