search

chocolatey / ChocoCCM

PowerShell module for interacting with Chocolatey Central Management
Apache License 2.0
9 stars 8 forks source link

New-CCMDeploymentStep -Type parameter feels redundant #37

Open vexx32 opened 3 years ago

vexx32 commented 3 years ago 
$step = @{
    Deployment   = $Deployment.Name
    Name         = 'Choco Upgrade All'
    TargetGroup  = $Group.Name 
    # why is this here?
    Type         = 'Basic' 
    ChocoCommand = 'upgrade' 
    PackageName  = 'all'
}
New-CCMDeploymentStep @step

I think the best way forward here is to remove the Type parameter completely (it's not really adding anything here) and just have the -Script or -ChocoCommand (and -PackageName) parameters be mandatory in their sets.

vexx32 commented 3 years ago

Amended because there isn't a pressing issue and I was just holding it wrong. I still think it might want to be changed, though.