chocolatey / choco

Chocolatey - the package manager for Windows
https://chocolatey.org
Other
10.16k stars 895 forks source link

Install-ChocolateyPackage / Install-ChocolateyInstallPackage add ahkFile option #1753

Open mkevenaar opened 5 years ago

mkevenaar commented 5 years ago

I think it would be an great addition to have an parameter to provide an ahkFile.

Your packageArgs could change into something like this:

$ahkFile = Join-Path $toolsDir 'chocolateyInstall.ahk'

$packageArgs = @{
  packageName    = $env:ChocolateyPackageName
  unzipLocation  = $toolsDir
  fileType       = 'exe'
  url            = $url
  checksum       = $checksum
  checksumType   = $checksumType
  softwareName   = 'My Awesome Software Name*'
  silentArgs     = ""
  ahkFile        = $ahkFile
  validExitCodes = @(0,3010)
}

Doing so, might require to distribute the portable edition of autohotkey with Chocolatey, just like 7zip

ferventcoder commented 5 years ago

We are not redistributing AHK. While I think the option might be a good one, we are not looking to redist more software that may or may not get identified as malware in common settings.

mkevenaar commented 5 years ago

@ferventcoder If we will not distribute ahk with Chocolatey, I think we should implement at least one of these:

verify usage of ahkFile usage and autohotkey.portable dependency when:

ferventcoder commented 5 years ago

Why not both? #602

mkevenaar commented 5 years ago

@ferventcoder Fine by me.