chop-dbhi / cilantro

Official client for Harvest (http://harvest.research.chop.edu)
http://cilantro.harvest.io
Other
28 stars 8 forks source link

Migrate away from using Bootstrap selectors in markup #488

Open bruth opened 10 years ago

bruth commented 10 years ago

This is motivated by this post: https://coderwall.com/p/wixovg which describes using Sass @extend to "mix-in" Bootstrap styles, but using your own semantics. I don't think this is necessarily the way to go either, but it got me thinking regarding a strategy for #96. According to Chrome, 97% of the CSS is not being used. However more of the concern is around making it more clear how to extend and/or theme Cilantro components. Bootstrap is certainly familiar, but for defining a theme with familiar terms relative to the components, it is hard to describe in terms of Bootstrap classes.

That all being said, a theme definition needs to be written up to understand the scope of the Cilantro UI and what all is required. As with any custom interface, components are refined in which the original styles/layout (default Bootstrap) is no longer used. For the boilerplate components, there are plenty of small libraries such as:

bruth commented 10 years ago

Interesting project to remove unused CSS https://www.npmjs.org/package/grunt-uncss