search

chown2 / lunaticvibesf

Lunatic Vibes F - a BMS client, a Lunatic Rave 2 clone
MIT License
9 stars 0 forks source link

Forced bilinear filter when upscaling #123

Open Sonic-TV opened 1 month ago

Sonic-TV commented 1 month ago

Title. The bilinear filter currently has some issues as well.

example: image

notice the little edges.

Sonic-TV commented 1 month ago

there's also a better option available. i.e. filter options (force none, bilinear, bicubic)

Vad1mCSO2 commented 1 month ago

so, we have forced enabled filter in CSV scripts. See https://right-stick.sub.jp/lr2skinhelp/base.html#dst_image

Sonic-TV commented 1 month ago

so, we have forced enabled filter in CSV scripts. See https://right-stick.sub.jp/lr2skinhelp/base.html#dst_image

there is indeed, but you don't want to manually edit them by hand when upscaling as it takes too much time....

Vad1mCSO2 commented 1 month ago

I can fix this skin to disable filter. Send me a LR2 skin to resolve it via Notepad++ with CSV Lint plugin

Sonic-TV commented 1 month ago

I can fix this skin to disable filter. Send me a LR2 skin to resolve it via Notepad++ with CSV Lint plugin

......actually the filters are need to be kept as it's a 480p skin originally.....

chown2 commented 1 month ago

Any quick way to reproduce this?

Sonic-TV commented 1 month ago

Any quick way to reproduce this?

Do you have any kind of contacts? I can send the skin to you.

chown2 commented 1 month ago

If possible, please, upload it here. If it's a public skin, I might already have or be able to easily find it. What's it called?

Sonic-TV commented 1 month ago

If possible, please, upload it here. If it's a public skin, I might already have or be able to easily find it. What's it called?

It's rather a non public skin I modded for testing, based on the GOLD skin back in '08ish.

Sonic-TV commented 1 month ago

If possible, please, upload it here. If it's a public skin, I might already have or be able to easily find it. What's it called?

You can use an OADX skin and try applying the filter to the entire skin though.

Sonic-TV commented 4 weeks ago

image image

after applying the 0.17.1 update the filter problem is still there. any ideas? (to represent it, use any 480p skin, try it on the numbers, and try set the element filter to 1.)

Sonic-TV commented 4 weeks ago

another comparison here. image left: filter 0, right, filter 1.

chown2 commented 4 weeks ago

Aha, so this issue actually contains two bugs - one for forced filter=1, another about little edges with filter=1. Forced filter=1 has been fixed, is that right?

Sonic-TV commented 4 weeks ago

Aha, so this issue actually contains two bugs - one for forced filter=1, another about little edges with filter=1. Forced filter=1 has been fixed, is that right?

Only the latter part. What I was going to say is you can add a feature that let the game force filtering the entire skin while upscaling, rather than manually change the skins CSV manually. Sorry for the inconveniences.