search

chr233 / ASFEnhance

ASF 扩展命令插件 / External commands for ASF
GNU Affero General Public License v3.0
489 stars 40 forks source link

!VOTE does not work for the 11 categories #169

Closed woctezuma closed 9 months ago

woctezuma commented 9 months ago

I have tried to vote for the 11 nominations:

!vote ASF 1868140,2296380,531640,1997040,1260320,1977170,1624540,1976950,1817230,1976950,2225070

My MainBot is fine, because I manually voted for it. However, the other bots have not cast a vote in each of the 11 categories.

>> !vote ASF 1868140,2296380,531640,1997040,1260320,1977170,1624540,1976950,1817230,1976950,2225070

<MainBot> Nominate at least 1 game: √
Nominate a game in each category: √
Play a game you nominated: √
Review or update your review of a game you nominated: √

<AltBot1> Nominate at least 1 game: √
Nominate a game in each category: ×
Play a game you nominated: ×
Review or update your review of a game you nominated: ×

<AltBot2> Nominate at least 1 game: √
Nominate a game in each category: ×
Play a game you nominated: ×
Review or update your review of a game you nominated: ×

<AltBot3> Nominate at least 1 game: √
Nominate a game in each category: ×
Play a game you nominated: ×
Review or update your review of a game you nominated: ×

This would probably be fixed by:

woctezuma commented 9 months ago

On a side-note, I have tried the following, yet it did not trigger Play a game you nominated for some reason.

!addlicense ASF a/2225070
!play ASF 2225070
!resume ASF

However, it worked for my MainBot yesterday. The reason why it fails now is due to the aforementioned issue: the number of nominations is truncated at 10 instead of 11. If I remove an appID so that 2225070 is the 10th instead of the 11th nomination, then the appID is not thrown away and I can "play" the app.

!vote ASF 1868140,2296380,531640,1997040,1260320,1977170,1624540,1976950,1817230,2225070
!addlicense ASF a/2225070
!play ASF 2225070
!resume ASF
>> !checkvote ASF

<MainBot> Nominate at least 1 game: √
Nominate a game in each category: √
Play a game you nominated: √
Review or update your review of a game you nominated: √

<AltBot1> Nominate at least 1 game: √
Nominate a game in each category: ×
Play a game you nominated: √
Review or update your review of a game you nominated: ×

<AltBot2> Nominate at least 1 game: √
Nominate a game in each category: ×
Play a game you nominated: √
Review or update your review of a game you nominated: ×

<AltBot3> Nominate at least 1 game: √
Nominate a game in each category: ×
Play a game you nominated: √
Review or update your review of a game you nominated: ×
reanoff commented 9 months ago

also marks 10 categories

Botan626 commented 9 months ago

I confirm, command vote bot1 with v2.0.1.1 doesn't vote in these categories: image image

reanoff commented 9 months ago

image I only have this one

victoronlyarg commented 9 months ago

I used the command with the apps id that you included without having seen the tasks before. Do you know if there is a way to delete the selected games?

reanoff commented 9 months ago

I used the command with the apps id that you included without having seen the tasks before. Do you know if there is a way to delete the selected games?

just enter other appid

chr233 commented 9 months ago

lol，i counted by 10, lost one category

wulala1337 commented 9 months ago

lol，i counted by 10, lost one category

更新了还是不行，还有2个类别就是不投票 1 2

chr233 commented 9 months ago

lol，i counted by 10, lost one category

更新了还是不行，还有2个类别就是不投票 1 2

  • ASF 版本: 5.4.13.4 - 插件版本: 2.0.1.2 ========================================================================== { "EULA": true, "Statistic": true, "DevFeature": false, "DisabledCmds": null, "Address": null, "Addresses": [] } ========================================================================== - 错误类型: System.ArgumentNullException - 错误消息: Value cannot be null. (Parameter 'format') at System.ArgumentNullException.Throw(String) at System.String.FormatHelper(IFormatProvider provider, String format, ReadOnlySpan1 args) at System.String.Format(String format, Object[] args) at ASFEnhance.Utils.AppendLineFormat(StringBuilder sb, String format, Object[] args) at ASFEnhance.Event.WebRequest.CheckSummerBadge(Bot bot) at ASFEnhance.Event.Command.ResponseSteamAwardVote(Bot bot, String gameIDs) at ArchiSteamFarm.Core.Utilities.InParallel[T](IEnumerable1 tasks) at ASFEnhance.Event.Command.ResponseSteamAwardVote(String botNames, String choose) at ASFEnhance.ASFEnhance.OnBotCommand(Bot bot, EAccess access, String message, String[] args, UInt64 steamId)

还真是，杰出视觉风格好像就是投不上

chr233 commented 9 months ago

lol，i counted by 10, lost one category

更新了还是不行，还有2个类别就是不投票 1 2

  • ASF 版本: 5.4.13.4 - 插件版本: 2.0.1.2 ========================================================================== { "EULA": true, "Statistic": true, "DevFeature": false, "DisabledCmds": null, "Address": null, "Addresses": [] } ========================================================================== - 错误类型: System.ArgumentNullException - 错误消息: Value cannot be null. (Parameter 'format') at System.ArgumentNullException.Throw(String) at System.String.FormatHelper(IFormatProvider provider, String format, ReadOnlySpan1 args) at System.String.Format(String format, Object[] args) at ASFEnhance.Utils.AppendLineFormat(StringBuilder sb, String format, Object[] args) at ASFEnhance.Event.WebRequest.CheckSummerBadge(Bot bot) at ASFEnhance.Event.Command.ResponseSteamAwardVote(Bot bot, String gameIDs) at ArchiSteamFarm.Core.Utilities.InParallel[T](IEnumerable1 tasks) at ASFEnhance.Event.Command.ResponseSteamAwardVote(String botNames, String choose) at ASFEnhance.ASFEnhance.OnBotCommand(Bot bot, EAccess access, String message, String[] args, UInt64 steamId)

image 我知道问题在哪里了，base64后的Protobuf有个 + 没有转义，得用url编码一下

chr233 commented 9 months ago

fixed in 2.0.1.3

wulala1337 commented 9 months ago

fixed in 2.0.1.3 感谢更新！下午试了很多号投票都成功了，就是依然报错，但是不影响投票。

chr233 commented 9 months ago

fixed in 2.0.1.3 感谢更新！下午试了很多号投票都成功了，就是依然报错，但是不影响投票。

image 忘记添加翻译文本了……，稍后手动传一个版本上去

chr233 commented 9 months ago

fixed in 2.0.1.3 感谢更新！下午试了很多号投票都成功了，就是依然报错，但是不影响投票。

修好了，手动发了一个 fix 版本