chr233 / ASFEnhance

ASF 扩展命令插件 / External commands for ASF
GNU Affero General Public License v3.0
473 stars 41 forks source link

Change output #286

Closed Botan626 closed 6 days ago

Botan626 commented 1 week ago

If ASFEnhance is up to date, it says this when checking for an update: Plugin name: ASFEnhance The plugin is up to date, no need to update

Please re-write this output in chinese, so it would be like this in english: ASFEnhance plugin is up to date, no need to update

and then I'll translate it in english on crowdin

chr233 commented 1 week ago

actually, its ASF's output

Botan626 commented 1 week ago

actually, its ASF's output

Are you sure?

Archi said it completely comes from ASFE: https://discord.com/channels/267292556709068800/332735075315744768/1258036409382731776

chr233 commented 1 week ago

image

deleted self-update logic in 2.1.11.x, now it will eval the "updateplugins" command

Botan626 commented 1 week ago

deleted self-update logic in 2.1.11.x, now it will eval the "updateplugins" command

But your self-update logic is still in ASFEnhance 2.1.11.0 right?

chr233 commented 6 days ago

deleted self-update logic in 2.1.11.x, now it will eval the "updateplugins" command

But your self-update logic is still in ASFEnhance 2.1.11.0 right?

nope, it already gone in 2.1.11.0

Botan626 commented 6 days ago

nope, it already gone in 2.1.11.0

Then why when updating ASF still says: INFO ASF > GetTargetReleaseURL() Plugin name: ASFEnhance The plugin is up to date, no need to update

chr233 commented 6 days ago

GetTargetReleaseURL is implemented by asfenhance, because ASF's default interface can't judge different language version of plugins "self-update logic" is the download and replace the binary login

Botan626 commented 6 days ago

GetTargetReleaseURL is implemented by asfenhance

that's what I'm talking about, can you change this output line: Plugin name: ASFEnhance The plugin is up to date, no need to update ?

chr233 commented 6 days ago

The plugin is up to date

this is just a log, does it effect anything?

Botan626 commented 6 days ago

this is just a log, does it effect anything?

It doesn't affect anything, but it's bad written and it's hard to read.

Please change it to ASFEnhance plugin is up to date, no need to update in chinese.

Botan626 commented 6 hours ago

Now it changed: INFO ASF > GetTargetReleaseURL() No update available for ASFEnhance plugin: 2.1.12.0 ≥ 2.1.12.0.