"Bitcoin node isnt reachable" after updating to Core 22.0

chris-belcher / electrum-personal-server

Maximally lightweight electrum server for a single user

MIT License

601 stars 110 forks source link

"Bitcoin node isnt reachable" after updating to Core 22.0 #251

Closed chris-belcher closed 2 years ago

chris-belcher commented 3 years ago

Reported by this guy https://twitter.com/8333Hydra/status/1451247140307673090

Reading the code I noticed the exception on this line: https://github.com/chris-belcher/electrum-personal-server/blob/91f36d7c9fcef2607646eebb88621625ae79ee2a/electrumpersonalserver/server/common.py#L50 isnt outputted anywhere not even to the debug log

chris-belcher commented 3 years ago

As this only started with core 22.0, it mustve been an update there. See the info in the twitter thread that this user was using blocksonly and the error message they got was "Fee estimation disabled".

I found the reason: https://github.com/bitcoin/bitcoin/pull/18766

I should possible revert the commit https://github.com/chris-belcher/electrum-personal-server/commit/cb6f76b0b39f059d2436fbc49e2761255e9a2559 because our user managed to get an error message without it