search

chris-hld / spaudiopy

Spatial Audio Python Package
https://spaudiopy.readthedocs.io/
MIT License
143 stars 15 forks source link

Fractional Octave Smoothing #34

Open nico-franco-gomez opened 3 months ago

nico-franco-gomez commented 3 months ago

Hi! I was looking at the implementation of the fractional octave smoothing function and stumbled across this line.

https://github.com/chris-hld/spaudiopy/blob/5f8af85445e41076ac1b91aaaedb432a6166fb57/spaudiopy/process.py#L404

I believe it has a bug because the spectrum is expected to be linearly-spaced. This window definition will have linear-axis symmetry but not the log-axis one, which is expected for the fractional octave smoothing (the highest point of the window lies in the arithmetic mean between the indices, but the geometric mean would be the right one...)

chris-hld commented 4 days ago

Hi! That's an interesting point - I believe the smoothing is done in linear spacing (therefore with a symmetrical window), and only the plotting then in log-spacing. Do you have an example where that fails/shows an issue?