chrisBrookes93 / robotframework-remoterunner

This library provides a robotframework agent, and accompanying robot executor script that allows you to run Robot Framework Test Suites remotely. It's designed to be a lightweight agent and can be used as an alternative, or with a CI Agent (e.g. Jenkins Agent).
MIT License
8 stars 8 forks source link

error parse library #18

Open embetrix opened 2 years ago

embetrix commented 2 years ago

For example specifying a Library with parameter

Library         SerialLibrary         encoding=ascii

leads to

raise DataError("%s '%s' does not exist." % (file_type, path))
robot.errors.DataError: Library 'SerialLibrary         encoding=ascii' does not exist.
embetrix commented 2 years ago

only the library name should be parsed and not the param(s)

chrisBrookes93 commented 2 years ago

Hi embexus,

This library was a prototype/experiment from a couple of years ago and isn't fully maintained.

Thanks for reporting the issue (as well as https://github.com/chrisBrookes93/robotframework-remoterunner/issues/18), give me a couple of days and I'll take a look into this.

Thanks

jayvynsong commented 1 year ago

@chrisBrookes93 Hi, Chris, remoterunner is really good, but I also encountered the problem. Have you found anything on it?

jayvynsong commented 1 year ago

I understand where the problem is now. The regular expression [ IMPORT_LINE_REGEX = re.compile('(Resource|Library)([\s]+)([^[\n\r]*)([\s]+)') ] cannot accommodate library declaration like [Library SSHLibrary WITH NAME SSH]. I will try to fix it. Should I modify on new fork?

embetrix commented 1 year ago

I use now gitlab-runner to trigger my Robot Gitlab CI and this plugin is for me not required anymore.

jayvynsong commented 1 year ago

I use now gitlab-runner to trigger my Robot Gitlab CI and this plugin is for me not required anymore.

I actually consider to use CI, but currently I have to stick to it.

chrisBrookes93 commented 1 year ago

Hey @jayvynsong,

I am travelling for 3 weeks and don't have access to a laptop so I will have to pick this up when I return. In the meantime, feel free to issue a fix on a fork.

And apologies @embetrix , I completely lost track of this!

Thanks

jayvynsong commented 1 year ago

Hey @jayvynsong,

I am travelling for 3 weeks and don't have access to a laptop so I will have to pick this up when I return. In the meantime, feel free to issue a fix on a fork.

And apologies @embetrix , I completely lost track of this!

Thanks

Thanks, working on fixing.