search

chrisjsewell / ipypublish

A workflow for creating and editing publication ready scientific reports and presentations, from one or more Jupyter Notebooks, without leaving the browser!
http://ipypublish.readthedocs.io
BSD 3-Clause "New" or "Revised" License
224 stars 37 forks source link

Allow configuration of initial section numbering via notebook metadata #113

Closed phelps-sg closed 5 years ago

phelps-sg commented 5 years ago

Implementation of feature request #112

chrisjsewell commented 5 years ago

Fixing your own issue, top man 👍 See review comments, and could you add a brief note in ipypublish/docs/source/metadata_tags.rst, to mention this is available (for slides only obviously)

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.05%) to 78.436% when pulling 7cef5c28b109aab9e9e544b341e46c30c8d960d3 on phelps-sg:develop into d252697aed6e21506a10250037be98aac4b5f0b7 on chrisjsewell:develop.

chrisjsewell commented 5 years ago

If you could just add a brief note in ipypublish/docs/source/metadata_tags.rst, to mention this is available (for slides only obviously) ta

phelps-sg commented 5 years ago

I have added the requested documentation. I'm not sure why the Codacy automated review is failing. Regarding the coverage check, would you like me to write more unit tests for the new code?

chrisjsewell commented 5 years ago

I'm not sure why the Codacy automated review is failing

Yeh it looks to not even be running. I might end up just ditching it.

would you like me to write more unit tests for the new code

Nah, if it works for you then great :)