search

chrisnorth / design-a-space-telescope

Web app to design a space telescope
http://chrisnorth.github.io/design-a-space-telescope/
2 stars 2 forks source link

IE fixes #18

Open slowe opened 9 years ago

slowe commented 9 years ago

@chrisnorth I see that you've made copies of the main files for some kind of bug fix for IE. What was the bug? What fixed it? I really don't think there should be forks of the main code for IE as then any changes have to be done in multiple files which makes mistakes more likely. Can we not have the IE-specific things in the main file?

chrisnorth commented 9 years ago

I tried to fix in main for bit couldn't, so made a fudge. The launch stuff didn't work in Safari or IE (gets a blank page, or does nothing). And IE11 doesn't honour the <!--if IE lt 9> type syntax.

If you go back to the point where I branched off for the IE version you may be able to make a better fix...

Sent from my phone. On 7 Jul 2015 15:22, "Stuart" notifications@github.com wrote:

@chrisnorth https://github.com/chrisnorth I see that you've made copies of the main files for some kind of bug fix for IE. What was the bug? What fixed it? I really don't think there should be forks of the main code for IE as then any changes have to be done in multiple files which makes mistakes more likely. Can we not have the IE-specific things in the main file?

— Reply to this email directly or view it on GitHub https://github.com/chrisnorth/design-a-space-telescope/issues/18.

slowe commented 9 years ago

Was it only broken in specific versions of IE?

chrisnorth commented 9 years ago

Send to be all when I tried it in (v11 and previous versions under emulation) Something up with whatever happens when the launch button is clicked. There were two calls to a function, and the Devon one didn't seem to happen.

Sent from my phone. On 7 Jul 2015 15:50, "Stuart" notifications@github.com wrote:

Was it only broken in specific versions of IE?

— Reply to this email directly or view it on GitHub https://github.com/chrisnorth/design-a-space-telescope/issues/18#issuecomment-119226854 .

slowe commented 9 years ago

Is "Devon" supposed to be "second" but autocorrected? I don't remember Devon being a launch site. ;)

chrisnorth commented 9 years ago

Yes ;-)

Sent from my phone. On 7 Jul 2015 15:58, "Stuart" notifications@github.com wrote:

Is "Devon" supposed to be "second" but autocorrected? I don't remember Devon being a launch site. ;)

— Reply to this email directly or view it on GitHub https://github.com/chrisnorth/design-a-space-telescope/issues/18#issuecomment-119229068 .

slowe commented 9 years ago

I've removed the forked files and added fixes that seem to work on IE11 on Windows 7 for me. @chrisnorth could you check for you?

chrisnorth commented 9 years ago

If I load the local version (in IE11) it has a white bar down the left with .

That means I can't try it out - do you know if there is a way of loading local pages in IE in sandbox mode?

chrisnorth commented 9 years ago

Just had a look at this - seems to work in IE 11 and under IE 10 emulation. However, using IE9 or previous (under emulation) the page doesn't load and I get the error:

SCRIPT5009: 'Blob' is undefined File: spacetelescope.js, Line: 278, Column: 3

Looks like that line is "if(is(Blob,"function")){"