chrisroberts / vagabond

Advocating idleness and work-shyness
Other
233 stars 25 forks source link

README.md file in roles/ directory busts role upload #16

Closed jaypipes closed 11 years ago

jaypipes commented 11 years ago

We have a README.md in our chef-repo's roles/ directory, and Vagabond doesn't like that :)

Vagabond exiting. Reason: Expected process to exit with [0], but received '30'
---- Begin output of knife role from file /home/jpipes/repos/att-cloud/chef-repo/roles/*  --server-url https://10.0.3.47 ----
STDOUT: 
STDERR: FATAL: File must end in .js, .json, or .rb
---- End output of knife role from file /home/jpipes/repos/att-cloud/chef-repo/roles/*  --server-url https://10.0.3.47 ----
Ran knife role from file /home/jpipes/repos/att-cloud/chef-repo/roles/*  --server-url https://10.0.3.47 returned 30

Would probably be more user-friendly to just output a warning like:

Skipping non-JSON/Ruby file in /roles (README.md)

Rather than fatal'ing out.

Anywho, not a big deal. Wishlist item only...

chrisroberts commented 11 years ago

:+1:

I think it will probably end up being best to just glob for supported file extensions within the directories (roles, environments, databags/*/_) so extraneous files like READMEs won't cause problems.

chrisroberts commented 11 years ago

Fixed with glob + extension based uploads