christianselig / apollo-bugs

A public bug tracker for Apollo, an iOS Reddit app
228 stars 15 forks source link

Linking to Comment directly displays root post (not comment) depending on URL #2077

Open hgnme opened 1 year ago

hgnme commented 1 year ago

Describe the bug Apollo isn’t linking directly to a comment when it’s cross posted. Instead it is linking to the OP of that comment.

To Reproduce Steps to reproduce the behavior:

  1. Open https://old.reddit.com/r/bestof/comments/142qfal/uusername_unavailable_offers_us_a_cautionary_tale in Apollo
  2. Tap on the crosspost in OP (https://old.reddit.com/r/NoStupidQuestions/comments/142eg6r/-/jn57mk9)
  3. Apollo loads the OP of that post, not the deeplinked comment
  4. Using the URL https://old.reddit.com/r/NoStupidQuestions/comments/142eg6r/_/jn57mk9 does link to the comment (note the - vs _ separator). This is commented by someone on the same BestOf post.

iOS version: 17.0 Dev Beta 1 Apollo version: 1.15.8 iOS device: 13 Pro Jailbroken: Noh Reproducible: 100%

Expected behaviour Expect Apollo to load the comment directly, though it goes to OP instead

Screenshots N/A

Video https://i.hgn.me/qknkd

Additional context I guess this is because the BestOf OP had a hyphen as the separator instead of an _ (between post and comment id)?