Open domyen opened 6 years ago
Maybe I can help with the Spanish translation.
can help @icarlossz with Spanish if needed.
Hello, It would be great if you use ISO 639-1 to url. e.g. /content/ja
, /content/es
, it looks more standard and url is short
@ng-hai definitely open to it if you're volunteering ๐
Hey, @domyen
About the plan of translate chinese ๐จ๐ณ #42 ๐
Hi @domyen, I can help you the the Portuguese translation
@fabioscsilva we'd be ๐ฏ thrilled to have you do that! Please send a PR ๐
Hey @domyen I can work on French translation starting with Angular.
@geromegrignon Yes please! The Angular editions don't have the recently added addon chapter yet, can you include that in your translation? ๐
ok, do you want me to make a PR to add this chapter to the Angular english version as well?
Yea thatโd be awesome ๐ On Thu, Dec 27, 2018 at 12:05 PM Gรฉrรดme Grignon notifications@github.com wrote:
ok, do you want me to make a PR to add this chapter to the Angular english version as well?
โ You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/chromaui/learnstorybook.com/issues/3#issuecomment-450192090, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQE2RBB5Z1i4NrAM4Ctiam1wMLMRsUwks5u9P3SgaJpZM4TFl7Z .
If you want i can help out with the portuguese translation. I will start with the react version and then move on systematically to the angular and vue documentation.
Yes weโd really appreciate it @jonniebigodes! @tmeasday is looking to update the tutorial to +4.x in the next couple of days so perfect timing ๐ On Fri, Dec 28, 2018 at 12:56 PM jonniebigodes notifications@github.com wrote:
If you want i can help out with the portuguese translation. I will start with the react version and then move on systematically to the angular and vue documentation.
โ You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/chromaui/learnstorybook.com/issues/3#issuecomment-450400633, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQE2WX-6WtuNBB5BxQwd-Gt_9mQO9eeks5u9ltGgaJpZM4TFl7Z .
Just to be clear I think the written text + code samples work more or less with 4.0 (let me know if not!). Itโs just the code repository is a little out of date. On 29 Dec 2018, 5:15 AM +1100, Dominic Nguyen notifications@github.com, wrote:
Yes weโd really appreciate it @jonniebigodes! @tmeasday is looking to update the tutorial to +4.x in the next couple of days so perfect timing ๐ On Fri, Dec 28, 2018 at 12:56 PM jonniebigodes notifications@github.com wrote:
If you want i can help out with the portuguese translation. I will start with the react version and then move on systematically to the angular and vue documentation.
โ You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/chromaui/learnstorybook.com/issues/3#issuecomment-450400633, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQE2WX-6WtuNBB5BxQwd-Gt_9mQO9eeks5u9ltGgaJpZM4TFl7Z .
โ You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
OK, and as soon as the tutorial is done, i'll pick up on it and proceed from there and start the translation. Sounds good?
@jonniebigodes sorry if I wasn't clear; what I meant was the tutorial should be good for v4 as it stands. It's just the code repository (https://github.com/chromaui/learnstorybook-code) hasn't yet been updated for v4. But if a user follows the steps in the tutorial it should work.
I'll be updating the code in the near future, but I am not sure how soon, perhaps within the next 2 weeks? I can't really say if it'll be sooner.
In theory the text will not change when I make those changes (as I am just bringing the code up to date with the text), although it's possible I'll discover some problems as I do so. So depending on your own schedule it'd make sense to either wait for me to make the update (to be absolutely sure you are translating the final text) or just do the translation now (if waiting a couple of weeks doesn't work for you).
@tmeasday sorry it was my mistake, i understood it wrong. I'm cloning the tutorial's repository and start working on the translations as we speak.
@tmeasday I think I can translate this into Korean, starting from React first, if you think it's okay.
๐ @moonformeli I'd be thrilled about a Korean translation.
๐ Shoutout to @jonniebigodes for shipping Portuguese!
I can do the Vue translation to spanish ๐จ๐ปโ๐ป
@icarlossz yes please!
almost finished with the vue translation
@domyen Quick question. Is it better to do PR with fully translated files than with partially translated files? :)
Fully translated is a bit easier. But if you end up submitting a PR with partial translations just mention that in the post and Iโll add a โdo not mergeโ tag. On Fri, Jan 25, 2019 at 5:43 AM moonformeli notifications@github.com wrote:
@domyen https://github.com/domyen Quick question. Is it better to do PR with fully translated files than with partially translated files? :)
โ You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/chromaui/learnstorybook.com/issues/3#issuecomment-457532174, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQE2e2vZfXkD1FHoeH8l9YlNK0koKTZks5vGt-9gaJpZM4TFl7Z .
@tmeasday just updated the English guide to the new Storybook 5.0. The translations could use a review so they stay up to date!
Mind taking a look @icarlossz @alterx @luchux @chinanf-boy @danielduan @jonniebigodes ๐
@domyen i've been keeping an eye on the twitter feed and saw the update. I was looking for a update on the guide so that i could make the changes on the translations. Going to start making the necessary adjustments starting tomorrow.
I'm not sure I made any text changes -- I updated the code snippets where required (very limited) in all the translations, and all the images are shared so should have just worked. You can check commits to be totally sure of course.
However I only did the React version. If someone has the time to walk through the Vue and/or Angular tutorials and see if there any problems that would be greatly appreciated.
I updated the source code for React too to use SB5. Ideally we'd do that for the other view layers too. I figure most people are on React so that's where I've put the time for now ๐
@domyen, Carlos reporting for duty :P I'll take a look to the Spanish and English versions of Angular during this week. I think there's also a new chapter that's missing for the Angular version, I'll add that one too.
I started translating of vue part to Russian in https://github.com/b0g3r/learnstorybook.com/tree/ru
Awesome!
Tom On 18 Mar 2019, 6:59 AM +1100, Dima Boger notifications@github.com, wrote:
I started translating of vue part to Russian in https://github.com/b0g3r/learnstorybook.com/tree/ru โ You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
@domyen Hi, I wanted to help with the Spanish translation for Vue. I didn't see anyone assigned but I wanted to make sure that I was able to contribute. If there is someone assigned can you please tell me what needs to be translated. Thanks a lot!
Hey @Ericnunez, I'm very busy rn so if you can help with the spanish translation I can help with reviews and anything that you need!
Hi @icarlossz , That sounds good! I''l start working on the documents and follow up when i'm ready for a review.
@icarlossz, Hey mate, just opened a pull request for my first translation. Could you review the file when you get a chance? Thanks!
@Ericnunez Looking now!
@domyen Sorry, missing i will take a look with chinese
@domyen up to date #87
I can do the Vue translation to Simplified Chinese.
I can help with Vue to Spanish
@jhta that'd be awesome!
I can make Vue translation to Japanese ๐ฏ๐ต
@53able we'd love your help on a Japanese version ๐.
@domyen I can help with the Korean translation for Angular!
That would be awesome ๐
On Wed, Sep 25, 2019 at 10:58 AM Seongkyu Lee notifications@github.com wrote:
@domyen https://github.com/domyen I can help with the Korean translation for Angular!
โ You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/chromaui/learnstorybook.com/issues/3?email_source=notifications&email_token=AACAJWISFSV4AYK2V5RK52TQLN4ANA5CNFSM4EYWL3M2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7SG3TA#issuecomment-535064012, or mute the thread https://github.com/notifications/unsubscribe-auth/AACAJWLVR77S5H3ZGQ6WBATQLN4ANANCNFSM4EYWL3MQ .
@domyen Iโm not sure if anyone has mentioned this or not, but if not I would be more than willing to translate Vue/Angular into Portuguese. Iโm fluent in Brazilian Portuguese.
@stephanbm That'd be sweet!
The "Intro to Storybook" guide is already translated to Portuguese but "Design Systems for Developers" is not. Would you be interested in helping with that?
@jonniebigodes expressed interest in the past so he might be keen to support you!
@domyen i'm almost done with the portuguese translation for the guide "Design Systems for Developers", as i type this. It still needs to be proof read. But technically is done. What i propose and if @stephanbm doesn't mind is the following, you make a portuguese brazilian version of the guides, start with the intro to storybook and i can help you with the react part of it, should you need help and if you're willing go through and translate the "Design Systems for Developers" aswell. As probably @domyen is not aware both languages are quite similar, more even now that the Portuguese Orthographic Agreement is in effect, but there are still some nuances to both variations of the language. Going over the intro guide there's some things that a portuguese would read and translate one way, that the brazilian would read and translate differently. More even with "Design Systems for Developers" guide, based on the way it's written, for instance some coloquialism that were used which i tried to translated them in a way that could be understood by both audiences.
Based on that probably use the same approach that is used for zh-CN and zh-Tw translations that is already in place. Create a folder for pt-pt and another for pt-br, update the file languageNameMap file, changing it to the following:
const languageNameMap = {
en: 'English',
es: 'Espaรฑol',
'zh-CN': '็ฎไฝไธญๆ',
'zh-TW': '็น้ซไธญๆ',
'pt-pt': 'Portuguรชs Portugal',
'pt-br:' 'Portuguรชs Brasil',
};
With this change i believe that the documentation will become more custom tailored and reach a bigger audience.
Feel free to provide feedback and i'll make the changes accordingly
@domyen I can help with React translation to Japanese. Started translation at : https://github.com/so99ynoodles/learnstorybook.com/tree/translate/japanese
@so99ynoodles thank you! Thrilled about the Japanese translation โ it was on my wishlist from day one!
I can help with the Dutch translation
Learn Storybook is read by over 300,000 developers! We need help translating the tutorial to other languages.
What's needed
Translating is manageable for one person. The content length is the equivalent to one long blog post (5โ6k words). Ideally, we try to have 2 people to collaborate on writing and proofreading, but that shouldn't prevent you from getting started.
Note: React/English is the "master" edition that is updated often. Please use React/English as the source-of-truth in your translations. ๐
How to get started
/react/jp
).Status
React
React Native
Angular
Vue
Svelte