chromiecraft / chromiecraft

ChromieCraft Discussions and Bug Tracker
https://www.chromiecraft.com
132 stars 30 forks source link

[Magtheridon] Debris damage location #6051

Closed NuariCC closed 1 year ago

NuariCC commented 1 year ago

What client do you play on?

enUS

Faction

Horde

Content Phase:

70

Current Behaviour

Magtheridon's Debris ability (30631) that he casts frequently in Phase 3 (<30% hp) is causing damage at incorrect location, resulting in players dying while being far away from the visual cave-in effect 30632.

According to my PTR testing, the Debris behaves in two different ways depending on whether it spawns on a player or not.

  1. IF the Debris visual (30632) spawns on top of a player, the damage ability (30631) will target that player (after 5 seconds) regardless of how far the player runs away from the cave-in.
  2. IF the Debris visual (30632) spawns anywhere else (i.e., not on top of any player), the damage ability (30631) will land somewhere in the proximity of the visual effect - sometimes at least partially overlapping with the visual effect but other times not.

I am attaching some screenshots from my PTR testing that show both of those cases (floating combat text is enabled to determine if Debris hit me or not).

Case 1

WoWScrnShot_081623_222938 WoWScrnShot_081623_222638

In both instances, the Debris visual originally appeard on top of me and even though I ran far away from the visual effect (seen to the right or left of my character), the damaging ability (that meteor visual) targeted me and landed on my character anyway.

Case 2

WoWScrnShot_081623_222859 WoWScrnShot_081623_222803 WoWScrnShot_081623_222918 WoWScrnShot_081623_222818

In all the screenshots, the Debris visual did not originally appear on top of me but rather at a random location. As the screenshots show, the damaging ability then (after 5 seconds) lands somewhere near the center of the visual effect. In the first two screenshots, it clearly lands far enough to not hit me even though I am standing right where the visual effect was, while the last two screenshots show that in some cases, the damaging ability will at least partially overlap with the visual effect.

Expected Blizzlike Behaviour

The Debris damaging ability (30631) should always land precisely in the center of the visual effect (30632) location. Debris should be a simple "void zone" type mechanic, meaning: you stand in it = you die; you run away = you live. The Debris damage component should not "follow" affected players or land "somewhere near" the visual effect.

Source

Timestamped Dungeon Dives strategy video for TBC Classic: https://youtu.be/NBP7T9QMad0?t=296

Strategy post on WoWhead: https://www.wowhead.com/wotlk/npc=17257/magtheridon#comments:id=2822532

Cave In, will occur periodically. The Cave In deals 90,000-113,000 damage to anyone standing in the Cave In. Each Cave In is preceded by a Cave In animation (approx. 3 seconds), which gives players enough time to move out of the Cave In (which will result in instant death).

Classic TBC - Magtheridon's Lair - Nova vs. Magtheridon 8:53: Debris visual spawning near one of the fire patches and the damage ability landing exactly at the location of the visual effect (hard to see because of the fire tho). 9:22: Debris visual spawning near the player, the damage ability landing precisely in the center of the visual effect a few seconds later.

World Of Warcraft: The Burning Crusade Classic - Magtheridon Boss Fight 7:31: Debris visual spawning in a fire patch, the damage ability landing again precisely in the center of the visual effect.

A blast from the past (vanilla TBC): Unknown Potential - Magtheridon TBC kill 8:59: Debris spawning once again in/near the fire patch and the damage ability landing precisely where the visual effect is.

Steps to reproduce the problem

  1. Teleport to Magtheridon's Lair (.teleport Magtheridon)
  2. Set HP high enough to survive a few minutes (e.g., .modify hp 100000000)
  3. Set movement speed higher as well to properly test the Case 1 (e.g., .modify speed all 6).
  4. Start the encounter, kill all the Channelers and get Mag below 30% to trigger phase 3.
  5. Wait for Mag to spawn Debris visual. If it spawns on top of you (Case 1), run as far away as you can and watch the damage ability (meteor) still target you and land at your new position. If it spawns somewhere else in the room (Case 2), get close to its location and watch where the damage ability lands.

Extra Notes

There is another report for Magtheridon's Debris ability (#5904), yet that report is about the buff/debuff status of the Debris visual effect (30632) and for that reason I would not consider this issue duplicate.

AC rev. hash/commit

https://github.com/chromiecraft/azerothcore-wotlk/commit/86bfef8874883a1726966326368918567c5531cd

Operating system

Ubuntu 20.04

Modules

Customizations

None

Server

ChromieCraft

balleny commented 1 year ago

https://github.com/chromiecraft/chromiecraft/issues/5904 is related but focuses on the debuff/combat log issue.

fixing this ticket here, should likely result in a solution for https://github.com/chromiecraft/chromiecraft/issues/5904 too

UndoUreche commented 1 year ago

I'm not a contributor to the project, but I was annoyed enough by this to check, and spotted two suspect bits: image image

Again, I'm not familiar with the api the folks have put together here, but what I'm reading is that in the context of mag picking a target, he will cast the visual effect on a player, followed by him then scheduling a debris damage event on said player. The event will then (after 5 seconds, as per the schedule) deal the debris damage to the affected player directly.

This seems to be the issue, but I would appreciate if somebody could confirm my suspicion