Remove `onError` event, fire `onClose` in all cases.

chromium / axiom

Axiom Project

https://chromium.github.io/axiom/web_shell/

Apache License 2.0

53 stars 26 forks source link

Remove `onError` event, fire `onClose` in all cases. #131

Closed rpaquay closed 9 years ago

rpaquay commented 9 years ago

One (wanted) side effect of this is that the setCallee method will cleanup the ExecuteContext.callee property in all cases of completion. Before this change, the callee member would not be cleaned up if a command would reject/closeError before calling cx.ready.

TBR @rginda