search

chromiumembedded / cef

Chromium Embedded Framework (CEF). A simple framework for embedding Chromium-based browsers in other applications.
https://bitbucket.org/chromiumembedded/cef/
Other
3.09k stars 450 forks source link

Fix dangling ResourceRequest* in InterceptedRequestHandlerWrapper #3719

Closed magreenblatt closed 1 week ago

magreenblatt commented 1 week ago

Describe the bug The current design of InterceptedRequestHandlerWrapper relies on dangling ResourceRequest* pointers, which is a violation of raw_ptr usage rules (see issue #3717, issue #3239). Refactor InterceptedRequestHandlerWrapper to fix this properly.

magreenblatt commented 1 week ago

We should stop binding |request| in MaybeLoadCookies and instead add a mechanism for retrieving it in ContinueWithLoadedCookies if the request is still valid. Maybe make it a raw_ptr<> member of RequestState.