chronogolf / nativescript-store-update

Apache License 2.0
19 stars 13 forks source link

Remove delegate implimentation, replace with app resume #22

Closed sitefinitysteve closed 6 years ago

sitefinitysteve commented 6 years ago
sitefinitysteve commented 6 years ago

Yes, this was in my note... So putting both triggers a double callback at launch

On Dec 13, 2017 1:52 PM, "Jeremy PELE" notifications@github.com wrote:

@jeremypele requested changes on this pull request.

In src/store-update.ios.ts https://github.com/chronogolf/nativescript-store-update/pull/22#discussion_r156748798 :

@@ -26,6 +23,11 @@ export class StoreUpdate { ...config, onConfirmed: StoreUpdate._openStore.bind(StoreUpdate), }) +

  • //Hook into resume event to check for version
  • app.on(app.resumeEvent, function (args) {
  • StoreUpdate.checkForUpdate();
  • });

Is the resumeEvent triggered at launch time ? If not I would implement launchEvent as well

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/chronogolf/nativescript-store-update/pull/22#pullrequestreview-83278441, or mute the thread https://github.com/notifications/unsubscribe-auth/ABeI6Gqfz37GU_2cV0uC8HT-yhtV1YX4ks5tAB0FgaJpZM4Q9lNk .

jeremypele commented 6 years ago

Ok right, didn't catch up this one. Thanks for the PR

sitefinitysteve commented 6 years ago

Thx guys!