search

chronotope / chrono

Date and time library for Rust
Other
3.35k stars 537 forks source link

Use environment secrets for Codecov token #1596

Closed djc closed 4 months ago

djc commented 4 months ago

It seems like there are some unexpected differences between "Repository secrets" and "Environment secrets" for GitHub repositories. In another repo, this seemed to help. (I've copied the token into the new Environment.)

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.75%. Comparing base (51c2d4b) to head (9ff8ba0). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1596 +/- ## ========================================== - Coverage 91.78% 91.75% -0.04% ========================================== Files 37 37 Lines 18207 18207 ========================================== - Hits 16712 16706 -6 - Misses 1495 1501 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pitdicker commented 4 months ago

We can't easily test this I think? What do you think about adding it as a commit to https://github.com/chronotope/chrono/pull/1594?

djc commented 4 months ago

It worked in this PR, right? Can rebase #1594 on top of this after it merges -- it certainly doesn't make anything worse.