search

chrvadala / react-svg-pan-zoom

:eyes: A React component that adds pan and zoom features to SVG
https://chrvadala.github.io/react-svg-pan-zoom/
MIT License
681 stars 127 forks source link

add rotate functionality #123

Closed culli closed 5 years ago

culli commented 5 years ago

This adds rotate to the available features. I could use some advice before this gets merged, because it causes an error to be logged even though it appears to work in the storybook.

Error: <rect> attribute height: A negative value is not valid. ("-800") in react-dom

I don't understand why it's doing that. Maybe it would be better to do the rotation using the svg rotate() transformation instead of matrix()?

chrvadala commented 5 years ago

This PR breaks a lot of viewer features, like the ability to pan the image, the miniature,.... Probably there's some extra work to do. In general, I think that the rotation is not so easy to develop but I can accept a fully working PR.

culli commented 5 years ago

While I would love to work on this more, I don't have the time right now, so I'm closing this PR.

chrvadala commented 5 years ago

Thanks anyway ;)