search

chsh2 / nijiGPen

An add-on of Blender focusing on Grease Pencil
GNU General Public License v3.0
290 stars 13 forks source link

Option to finish smart fill instantly #46

Closed Splits285 closed 8 months ago

Splits285 commented 9 months ago

I like the fill hints tool but I find it hard to work with fills when I don't know what their final result is going to be, and reaching for the enter key to confirm can be taxing on the hand. I attempted to program this in myself, but self.smart_fill_finalize() being run too quickly doesn't let anything get drawn. I can't figure out what to look for to be sure that the fill was drawn before finishing the modal.

Having seen how blender refuses to give useful finish signals to operators I'm not even ready to believe it's possible. If it isn't, that's ok.

chsh2 commented 8 months ago

Yes I think I can add an option to switch between the interactive mode and single-click mode.

And maybe in addition to the Enter key, the middle mouse button can be used for confirmation? So that interactive filling can be done with the mouse only.

Splits285 commented 8 months ago

Perhaps allowing any button to bind would work best, I use mouse4 to erase because of a special configuration I have on my pen.

chsh2 commented 8 months ago

I added an option to finish filling after a single click. But from my personal experience, it often does not give a perfect result without more hints made by user.

For the interactive mode, it might be difficult to allow arbitrary key bindings, because detecting Blender keymaps during a modal is tricky. Currently, I limit the binding to mouse buttons only. Later I may investigate if there is a better solution. 1

I also try to render clickable buttons on the screen for a better touchscreen control. 2

Splits285 commented 8 months ago

Thanks so much man, you're a god.