search

chuanqisun / spacemouse-anywhere

Bring 3DConnexion SpaceMouse to more places on the web
MIT License
19 stars 3 forks source link

added Sparkfun Pro Micro to id filter #14

Closed gocivici closed 1 year ago

gocivici commented 1 year ago

Hi! I'm working on an Arduino-compatible open-source space mouse. I added the id codes for the Arduino to the id filter to make this tool compatible with DIY devices. I also commented the gamepad.axes.length !== 6 to make room for devices that have more or less then 6 axes.

chuanqisun commented 1 year ago

Hi @gocivici, since I don't have the hardware, were you able to build the plugin and test it in Figma?

gocivici commented 1 year ago

Hi @chuanqisun, yes I tested the plugin in the Figma desktop app. Here's a video showcasing the plugin running in dev mode with arduino pro micro.

chuanqisun commented 1 year ago

That's awesome. I'll publish a release with your change shortly. Thank you for the test video!

chuanqisun commented 1 year ago

@gocivici, I have just published the plugin to Figma with minor refactoring of your code. My goal is to keep the SpaceMouse and SparkFun logic separate so it's easier to maintain in the future. Could you do a quick check to see if the published version works for you?

gocivici commented 1 year ago

Thanks @chuanqisun! That makes sense, I tested it just now and it doesn't work with the Sparkfun board. In my initial edit, I added both gamepadName.indexOf("vendor: SparkFun Pro Micro") and gamepadName.indexOf("vendor: 1b4f") to the list but it looks like only the vendor ID is recognized. Replacing "vendor: SparkFun Pro Micro" with "vendor: 1b4f" would solve this issue.

chuanqisun commented 1 year ago

😅that was entirely my mistake. I did that merge without actually testing. I switched to your original vendor hex id and republished the plugin. Thank you for testing and please let me know if it working now.

gocivici commented 1 year ago

It's working perfectly now thanks!