search

chulkilee / ex_force

A Salesforce REST API wrapper for Elixir
https://hex.pm/packages/ex_force
MIT License
38 stars 28 forks source link

add `describe_global` api endpoint #18

Closed mindreframer closed 6 years ago

sourcelevel-bot[bot] commented 6 years ago

Hello, @mindreframer! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.9%) to 92.929% when pulling 3e291334359c9b384baf903e39994b256828cfab on ruby2elixir:master into ca53862668601217f1b925cc5141d0f94cd6292d on chulkilee:master.

chulkilee commented 6 years ago

Thanks for the pull request! Could you add test for this? Please use real but shortened response. Check out other tests :)

chulkilee commented 6 years ago

@mindreframer could you rebase it onto master and add a test for this?

Thanks!

chulkilee commented 6 years ago

Thanks for the contribution - I rebased with fixes, and added test at #23