chunky-dev / chunky-denoiser

A denoising plugin for Chunky.
GNU General Public License v3.0
29 stars 8 forks source link

When using `DenoisedPathTracer` only denoised is outputted to `snapshots` #34

Open jackjt8 opened 2 years ago

jackjt8 commented 2 years ago

Tested on Chunky 2.4.0 with #30

In past versions of the plugin both the beauty pass and the denoised beauty would be exported to snapshots. Currently, when using the DenoisedPathTracer Renderer only denoised beauties are outputted to snapshots. The option the Save beauty pass within the Denoiser Tab only applies to the beauty .pfm.There are a multitude of benefits from having the option to still export the noisy snapshots.

1) #33 shows that denoising behaviour is mixed and that when using the Denoise Current Render button both the noisy and denoised beauty are snapshotted. Ideally we would want consistency with how denoising works.

2) The options listed within the Denoiser Tab lack clarification as to what they do. Expanding the visible descriptions or adding tooltips would help clear things up.

3) Disabling or redirecting inbuilt functionality without having an option to retain defaults and to export the denoised output with a suffix, as was done in the past with .denoised, should be avoided.